Skip to content

[v2] Event update time bug#7090

Merged
pingsutw merged 2 commits intoflyteorg:v2from
machichima:event-update-time
Mar 25, 2026
Merged

[v2] Event update time bug#7090
pingsutw merged 2 commits intoflyteorg:v2from
machichima:event-update-time

Conversation

@machichima
Copy link
Member

Tracking issue

Why are the changes needed?

Currently events may have wrong update time (e.g. running phase duration = 0 sec)

image

What changes were proposed in this pull request?

  • When sending the action event from controller, use the phase OccurredAt
  • In run service, mergeEvents will sort by updated time (fallback to record time if having same updated time)

How was this patch tested?

Running in sandbox and ensure UI shows the progress bar correctly
image

Labels

Please add one or more of the following labels to categorize your PR:

  • added: For new features.
  • changed: For changes in existing functionality.
  • deprecated: For soon-to-be-removed features.
  • removed: For features being removed.
  • fixed: For any bug fixed.
  • security: In case of vulnerabilities

This is important to improve the readability of release notes.

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: machichima <nary12321@gmail.com>
Signed-off-by: machichima <nary12321@gmail.com>
@pingsutw pingsutw merged commit a8d8f23 into flyteorg:v2 Mar 25, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants